eclipse-vertx / eclipse-vertx/vert.x

Future#fromCompletionStage(CompletionStage) with Context if it exists

Open
#4,978 2 comments 1 reaction 0 assignees View on GitHub
enhancement
Dominant language
Java
Stars
14.7k
Forks
2.1k
Avg merge
2d 7h
Merged PRs (30d)
28

Description

Current version:
```
static Future fromCompletionStage(CompletionStage completionStage) {
Promise promise = Promise.promise();
completionStage.whenComplete((value, err) -> {
```
isn't it better to supply Vert.x context if it "exists"
```
static Future fromCompletionStage(CompletionStage completionStage) {
Context ctx = Vertx.currentContext();
Promise promise = (ctx instanceof ContextInternal) // ⇒ ≠ null
? ((ContextInternal)ctx).promise()
: Promise.promise();
completionStage.whenComplete((value, err) -> {

```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.