eclipse-uprotocol / eclipse-uprotocol/up-spec

Make payload_format field in uattributes.proto optional

Open
#327 0 comments 1 reaction 1 assignee Claimed by @sophokles73 View on GitHub
breaking change enhancement
Dominant language
Gherkin
Stars
43
Forks
29
Avg merge
20m
Merged PRs (30d)
3

Description

Currently, the UAttributes message in [uattributes.proto]() is _not_ defined as optional. This results in any UAttributes object that has been deserialized from such a protobuf, to have an `UNSPECIFIED` payload format, even if the message itself does not have any payload at all. This is confusing (at best) and requires special handling in implementations of the object model.

IMHO we should declare the _payload_format_ field of the UAttributes message in uattributes.proto as _optional_.

@PLeVasseur @AnotherDaniel WDYT?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.