eclipse-thingweb / eclipse-thingweb/node-wot
Browser UI - CORS issue / question
- Dominant language
- TypeScript
- Stars
- 192
- Forks
- 100
- Avg merge
- 3d 2h
- Merged PRs (30d)
- 6
Description
The current browser UI does not yet include HTTPS client factory.
https://github.com/eclipse/thingweb.node-wot/blob/a376fed88d5c7b672c6c4011adb96f7d54125bce/examples/browser/index.js#L166-L168
Since I wanted to read a TD from an https URL (e.g., https://siemens-wot.demo.logilab.fr/)
I thought adding
`servient.addClientFactory(new Wot.Http.HttpsClientFactory());`
might do the job.
Unfortunately I run into CORS issues.
Questions:
Does it mean that the server https://siemens-wot.demo.logilab.fr needs to set the CORS header as we do in our HTTP Server?
https://github.com/eclipse/thingweb.node-wot/blob/a87715d159597c3a7084887e4f126ebee3a6a764/packages/binding-http/src/http-server.ts#L533-L534
Sorry for my naive questions.. I always struggle to understand the CORS requirements 🤷♂️🙃
Contributor guide
Assessment
This issue has not been assessed yet.