eclipse-thingweb / eclipse-thingweb/node-wot

[binding-http] Server side security scheme validation skipped when using `http`

Open
#260 4 comments 0 reactions 0 assignees View on GitHub
binding-http enhancement
Dominant language
TypeScript
Stars
192
Forks
100
Avg merge
3d 2h
Merged PRs (30d)
6

Description

As the title mention, the HTTP server does not verify if a `SecurityScheme` defined by an exposed thing is among the supported schemes or not. As it can be seen the validation is done only if the server is started with `secure` mode (i.e. https) whereas it is skipped if it is in HTTP mode (see [here](https://github.com/eclipse/thingweb.node-wot/blob/master/packages/binding-http/src/http-server.ts#L280)).

Now, should we reject any exposed thing with `SecurityScheme` other than `nosec`, or should we still allow to use a security scheme even over HTTP?(maybe just print a warning?)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.