eclipse-thingweb / eclipse-thingweb/node-wot
ExposedThing handleUnsubscribeEvent and handleUnobserveProperty should be async
Open
core
- Dominant language
- TypeScript
- Stars
- 192
- Forks
- 100
- Avg merge
- 3d 2h
- Merged PRs (30d)
- 6
Description
In `ExposedThing` we have
https://github.com/eclipse-thingweb/node-wot/blob/8dc6ed8d7a7fd24ef97d703c018a5ec1cd76481a/packages/core/src/exposed-thing.ts#L575
and
https://github.com/eclipse-thingweb/node-wot/blob/8dc6ed8d7a7fd24ef97d703c018a5ec1cd76481a/packages/core/src/exposed-thing.ts#L642
Both are not `async` while the counterpart of `handleSubscribeEvent` and `handleObserveProperty` are `async`.
Both call async functions (`unsubscribe`/`unobserveHandler`)
I think we ought to change them. Opinions?
Contributor guide
Assessment
This issue has not been assessed yet.