eclipse-thingweb / eclipse-thingweb/node-wot
[test] Convert unhandledRejection to uncaughtException
- Dominant language
- TypeScript
- Stars
- 192
- Forks
- 100
- Avg merge
- 3d 2h
- Merged PRs (30d)
- 6
Description
As mentioned in https://github.com/eclipse-thingweb/node-wot/pull/1298 by @relu91 (see here https://github.com/eclipse-thingweb/node-wot/pull/1298#discussion_r1666540417) mocha ignores the new nodejs mechanism of reporting async unhandled exceptions.
We need to set
`mocha --unhandled-rejections=strict --require ts-node/register --extension ts`
in all package.json files.
Doing so for `binding-http` shows already some issues.
see https://github.com/eclipse-thingweb/node-wot/pull/1298#discussion_r1668559113
plus: we also might want to rework the test introduced in https://github.com/eclipse-thingweb/node-wot/pull/1298 by simply doing something like
`(await text(data.body)).should.eql("Test event");`
Contributor guide
Assessment
This issue has not been assessed yet.