eclipse-thingweb / eclipse-thingweb/node-wot

Enable `@typescript-eslint/no-unnecessary-condition` rule

Open
#1,177 2 comments 0 reactions 1 assignee Claimed by @ViRUS-0-0 View on GitHub
good first issue refactoring
Dominant language
TypeScript
Stars
192
Forks
100
Avg merge
3d 2h
Merged PRs (30d)
6

Description

In the context of #1176, I noticed that we currently perform a lot of checks and nullish coalescing that are actually not really necessary based on our current typings. In some cases, this makes the code less readable, in other cases this can pave the way for potential bugs since some possible null values are hidden behind typecasts.

`eslint` provides the rule [`@typescript-eslint/no-unnecessary-condition`](https://typescript-eslint.io/rules/no-unnecessary-condition/) which makes it possible to detect and fix these problems. As another step toward more type safety, this rule could be added on a per-package basis again, which should ultimately make the library more reliable.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.