eclipse-thingweb / eclipse-thingweb/node-wot

Review and fix the purpose of `updateXFormWithTemplate`

Open
#1,029 1 comment 0 reactions 0 assignees View on GitHub
core Discuss in Committer Meeting enhancement
Dominant language
TypeScript
Stars
192
Forks
100
Avg merge
3d 2h
Merged PRs (30d)
6

Description

> If I recall correctly those set of methods are meant to update the form generated by the binding, trying to fulfill what the user set in the `PartialTD` passed in the `produce` method. My guess is that using them in two different bindings causes some possible collisions 🤔 . However, the methods are poorly implemented and I think we should review them in the future. I propose merging this PR and keeping track of this issue.

_Originally posted by @relu91 in https://github.com/eclipse-thingweb/node-wot/issues/1026#issuecomment-1595812182_

**Additional context**

The issue is about the methods in the [ProtocolHelpers](https://github.com/eclipse-thingweb/node-wot/blob/master/packages/core/src/protocol-helpers.ts#L63) class

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.