eclipse-score / eclipse-score/time

Bugfix: copyright_checker should reference //:docs_sources

Open
#134 0 comments 0 reactions 1 assignee Claimed by @ryan-steel View on GitHub
bug
Dominant language
C++
Stars
2
Forks
12
Avg merge
3d 10h
Merged PRs (30d)
24

Description

## Description

The copyright_checker target currently references the `"docs"` directory directly, but should reference `//:docs_sources` filegroup instead for consistency with other S-CORE repos and to ensure all documentation files are scanned. Right now the copyright_checker doesn't actually check our documentation source files, but rather the bazel build directory files.

## Current Behavior

```python
copyright_checker(
name = "copyright",
srcs = [
".github",
"docs", # Direct directory reference
"examples",
"score",
"tools",
"//:BUILD",
"//:MODULE.bazel",
],
)
```

## Expected Behavior

Should reference the `docs_sources` filegroup created by the `docs()` macro:

```python
copyright_checker(
name = "copyright",
srcs = [
".github",
"//:docs_sources", # Use filegroup
"examples",
"score",
"tools",
"//:BUILD",
"//:MODULE.bazel",
],
)
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.