Make clang-tidy CI gate blocking: fix all violations

> [!IMPORTANT]
> Link the implementing PR to this issue by including `Closes #`
> in the PR description or commit message.

### What

Remove `continue-on-error: true` from the `QA / Clang-Tidy` CI job so that
unresolved clang-tidy violations block PR merges.

The flag was added intentionally when the job was introduced because the codebase
had pre-existing violations. Once all violations tracked in #76, #77, #78, #79
are fixed, this gate can be made blocking.

### Acceptance Criteria

- [ ] All clang-tidy violations resolved across all components (see #76, #77, #78, #79)
- [ ] `continue-on-error: true` removed from the `clang-tidy` job in `.github/workflows/clang-tidy.yml`
- [ ] `QA / Clang-Tidy` CI job passes without violations on a clean branch

### References

- Clang-tidy CI job introduced in: #42
- SCA fix tasks (blockers): #76, #77, #78, #79