eclipse-score / eclipse-score/lifecycle

Use common naming convention for mocks

Open
#422 2 comments 0 reactions 1 assignee Claimed by @cameron-craig-etas View on GitHub
cleanup
Dominant language
C++
Stars
6
Forks
34
Avg merge
2d 3h
Merged PRs (30d)
80

Description

Currently, in score/launch_manager/ there are mocks defined with various filename patterns:

score/launch_manager/src/lifecycle_client/src/mwlifecyclemanagermock.h
score/launch_manager/src/lifecycle_client/src/lifecyclemanagermock.cpp
score/launch_manager/src/lifecycle_client/src/report_running_mock.h
score/launch_manager/src/lifecycle_client/src/report_running_mock.cpp
score/launch_manager/src/lifecycle_client/src/applicationcontextmock.cpp
score/launch_manager/src/lifecycle_client/src/lifecyclemanagermock.h
score/launch_manager/src/lifecycle_client/src/mwlifecyclemanagermock.cpp
score/launch_manager/src/lifecycle_client/src/applicationcontextmock.h
score/launch_manager/src/daemon/src/process_group_manager/details/mock_component_event_queue.hpp
score/launch_manager/src/daemon/src/process_group_manager/details/mock_termination_callback.hpp
score/launch_manager/src/daemon/src/process_group_manager/details/mock_component.hpp

We should decide for a single pattern and rename all files accordingly.

Note that mocks under score/launch_manager/src/lifecycle_client/src/ are exposed to users, so renaming those files is a breaking change.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.