eclipse-score / eclipse-score/communication

Improvement: Reenable BidirectionalTransport tests for all configurations

Open
#712 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
62
Forks
97
Avg merge
1d 1h
Merged PRs (30d)
72

Description

### What

Currently the tests for the LoLa gateway's BidirectionalTransport in bidirectional_transport_test.cpp are disabled for QNX and the tsan (thread sanitizer) configurations.

- The constraint for Linux only (no QNX) has been added because cc_test has been used, because a higher timeout value is needed.

- The constraint for no_tsan has been added because with the tsan configuration the tests became flaky due to timeouts.

Goal of this task would be to analyze how these tests can be adapted/restructured so that all configurations can be enabled.

### How

_No response_

### Estimates for realization

Low effort and low risk.
No impact on users of feature as test only.

### Category

- [ ] Affects Detailed Design

### Requirements / Architecture

- [x] Requirements / Architecture are not affected by this change?

Contributor guide

Open the contributing guide

Research direction

Start with bidirectional_transport_test.cpp and inspect the cc_test constraints that exclude QNX and tsan, then run the affected tests under those configurations to reproduce the timeout or flakiness. Restructure or adapt the tests so they run reliably in Linux, QNX, non-tsan, and tsan configurations, with all configurations enabled and no timeout failures.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
testing
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.