eclipse-score / eclipse-score/communication

Improvement: Make rules_python a dev dependency

Open
#278 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
62
Forks
97
Avg merge
1d 1h
Merged PRs (30d)
72

Description

### What

Right now rules_python is not a dev dependency because a target in the top level BUILD file requires it.
Bazel always evaluates top level targets and because of that our users will need rules_python.

### How

- Create a test to check that the module can be integrated
- Move the target depending on rules_python to a different location
- Make rules_python a dev dependency
- Make sure that the module is still integratable

### Estimates for realization

The highest risk is that we declare it as dev dependency when it is not. In that case the users would get a failure on integrating. This risk needs to be minimized by adding a test for it.
The test is what most probable will take most of the time to implement that. Moving the target should be trivial.

### Category

- [ ] Affects Detailed Design

### Requirements / Architecture

- [x] Requirements / Architecture are not affected by this change?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.