eclipse-platform / eclipse-platform/eclipse.platform

[Dark mode] The Registers View does not display the icons properly in dark mode

Open
#2,308 1 comment 0 reactions 0 assignees View on GitHub
bug
Dominant language
Java
Stars
165
Forks
174
Avg merge
2d 8h
Merged PRs (30d)
22

Description

Description

The Registers View has a UI issue: the icon from the general registers is not visible in dark mode while debugging

Dark Theme Icon Visibility: The Registers View icons (1010/0101) are not visible in dark mode. The icons appear to be dark-colored on dark background, making them hard to see. This issue is particularly problematic in S32DS which uses Eclipse CDT's Registers View directly without modifications but applies a dark theme.

To Reproduce

Steps to reproduce the issue:
Enable dark theme in Eclipse (Window -> Preferences -> General -> Appearance -> Theme: Dark)
Open Registers View: 'Window -> Show View -> Debug -> Registers
Set a breakpoint in eclipse for a .c file and debug (registers view is not visible for .java files)
Select the suspended thread in Debug View
Observe that Registers View remains empty despite active debug context

Note: the icons are declared [here](https://github.com/eclipse-platform/eclipse.platform/blob/0edd6a1b093e9915a6753f4e8ed19e9e78bdf0ad/debug/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/DebugPluginImages.java#L183-L184)

Expected behavior
Icon Visibility: The Registers View icons should be clearly visible in both light and dark themes. Icons should either:

Use theme-aware colors that adapt to the background
Use contrasting colors/borders that work on both light and dark backgrounds

Screenshots
In general registers, on the left side of the row there is a faint image of the icon. You can also see it at the top of the view, where it is more visible
Image

Version Information:

OS & version: Windows 11
Eclipse IDE/Platform version: Eclipse IDE 2023-12 (4.30.0)
Build id: 20231201-2043
CDT Version: 11.4.0
Java version: OpenJDK 17.0.9

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.