eclipse-paho / eclipse-paho/paho.mqtt.python

Incorrect handling of DISCONNECT packet

Open
#860 1 comment 0 reactions 0 assignees View on GitHub
Status: Available
Dominant language
Python
Stars
2.4k
Forks
742
Avg merge
12d 48m
Merged PRs (30d)
1

Description

I believe the handling of DISCONNECT (at least for MQTT 5) isn't correct:

https://github.com/eclipse/paho.mqtt.python/blob/d45de3737879cfe7a6acc361631fa5cb1ef584bb/src/paho/mqtt/client.py#L4021C1-L4022C1

I'm using paho as a test client and it doesn't seem to be correctly handling a DISCONNECT packet with a non-zero reason code and zero length properties (i.e. Remaining_Length = 2).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.