eclipse-paho / eclipse-paho/paho.mqtt.java

Mqtt5 client not reporting DUP flag correctly (always false) on reception of PUB message

Open
#874 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
2.3k
Forks
919
PR merge metrics
No merged PRs in 30d

Description

Please fill out the form below before submitting, thank you!

Yes mqttv5 client only- [ ] Bug exists Release Version 1.2.5 ( Master Branch)
- [ ] Bug exists in MQTTv3 Client on Snapshot Version 1.2.6-SNAPSHOT (Develop Branch)
Did not test. Do not see in maven repository- [ ] Bug exists in MQTTv5 Client on Snapshot Version 1.2.6-SNAPSHOT (Develop Branch)

The DUP setting of a received MQTTv5 PUB message is not correctly reported and is always false using the MqttMessage.isDuplicate() API i/f.
Note that this has degraded and v3 client reports DUP=true correctly.
The DUP flag is processed correctly by MqttWireMessage:createWireMessage .
However the relay to the callback receiver is neglecting this DUP setting:
ClientState:notifyReceivedMsg -> MqttPublish:getMessage -> MqttMessage(byte[] payload, int qos, boolean retained, MqttProperties properties)

If this is a bug regarding the Android Service, please raise the bug here instead: https://github.com/eclipse/paho.mqtt.android/issues/new

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.