eclipse-lsp4e / eclipse-lsp4e/lsp4e
LSP4E always mark code assist as TriggerCharacter if character under cursor is on completionTriggerChars list
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 85
- Forks
- 69
- Avg merge
- 8h 33m
- Merged PRs (30d)
- 6
Description
This is follow up issue (see #794)
For now, due Eclipse limitation, IContentAssistProcessor never know if it was invoked by character (auto completion), or on demand (assist) so if character under cursor in on completionTriggerChars, LS request is always marked as TriggerCharacter
If assist is invoked by character (via AutoAssistListener which is part of platform ContentAsistant), LS should recive kind: CompletionTriggerKind.TriggerCharacter, is invoked by ctrl/cmd+space LS should receive CompletionTriggerKind.Invoked
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the follow-up context in issue #794 and inspect IContentAssistProcessor, AutoAssistListener, and the code that creates the language-server completion request. Compare auto-assist invocation with Ctrl/Cmd+Space so character-triggered requests use CompletionTriggerKind.TriggerCharacter and on-demand requests use CompletionTriggerKind.Invoked; verify both paths with the project's relevant tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100