eclipse-lsp4e / eclipse-lsp4e/lsp4e

LSP Progress support should take care of cancellable

Open
#742 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
85
Forks
69
Avg merge
8h 33m
Merged PRs (30d)
6

Description

In LemMinx maven we have supported LSP progress when local artifacts are loaded:

257000901-5d105498-108f-4ec2-bb61-31404fc2449a

It works great but:

  • the progress monitor display a stop button altough the lemminx maven says that it is not cancellable
  • when I click on the stop button it stops the progress bar but it doesn't cancel the lemminx maven process. I think LSP4E should cancel the LSP progress future.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing LSP4E's LSP progress handling and how the progress monitor represents cancellability. Reproduce the stop-button behavior with a non-cancellable LemMinx Maven operation, then verify that stopping the monitor cancels the LSP progress future and the running process, while non-cancellable work does not expose a stop button.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
developer-experience, tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.