eclipse-lsp4e / eclipse-lsp4e/lsp4e
LSP Listener to be notified that a didChange has been done
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 85
- Forks
- 69
- Avg merge
- 8h 33m
- Merged PRs (30d)
- 6
Description
In WWD we use XML language server to consume a LSP command from the XML language server to manage auto close tag.
When we consume this LSP command we must be sure that the didChange has been done before consume it, because we must be sure that TextDocument on XML language server side has been updated.
Today we use the uggly code with Thread.sleep https://github.com/eclipse-wildwebdeveloper/wildwebdeveloper/blob/4998f935382c703a7776f37053993eae19848942/org.eclipse.wildwebdeveloper.xml/src/org/eclipse/wildwebdeveloper/xml/internal/autoclose/XMLAutoCloseTagReconciler.java#L129 which could create a deadlock https://github.com/eclipse/lemminx-maven/issues/332#issuecomment-1385482003
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading XMLAutoCloseTagReconciler.java around line 129 in the linked Wild Web Developer code, where Thread.sleep currently coordinates the operation. Trace how lsp4e sends or observes didChange notifications and determine where a listener can be notified after completion. Done means the caller can wait for the notification without Thread.sleep or the associated deadlock risk.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100