eclipse-lsp4e / eclipse-lsp4e/lsp4e
Read from the editor preference store, not the global preference store, to retrieve formatting settings
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 85
- Forks
- 69
- Avg merge
- 8h 33m
- Merged PRs (30d)
- 6
Description
See the discussion going on at https://github.com/eclipse/wildwebdeveloper/issues/474, from https://github.com/eclipse/wildwebdeveloper/issues/474#issuecomment-1247735627 onwards
Currently LSP4E seems to read formatting settings like 'insert tabs for spaces' from the global preference store. Projects like https://github.com/angelozerr/ec4e however allow customizing such settings on a project by project basis and offers more settings, like trim_trailing_whitespace and insert_final_newline.
It would make the dev experience so much better if the settings from .editorconfig, applied to the editor preference store by ec4e, would get picked up by LSP4E for the FormattingOptions for documentFormatting, rangeFormatting and onTypeFormatting commands
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the formatting paths for documentFormatting, rangeFormatting, and onTypeFormatting, and compare how LSP4E reads the global and editor preference stores. Review the linked discussion and the LSP FormattingOptions specification; done means .editorconfig-derived editor settings, including the listed whitespace options, are used for all three commands.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- developer-experience, tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100