eclipse-lsp4e / eclipse-lsp4e/lsp4e
Reading of `scrollWidth` or `scrollHeight` occasionally fails
Open
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 85
- Forks
- 69
- Avg merge
- 8h 33m
- Merged PRs (30d)
- 6
Description
The following errors are sometimes logged when quickly hovering over different parts of a document:
org.eclipse.swt.SWTException: Cannot read properties of null (reading 'scrollWidth')
at org.eclipse.swt.browser.Edge.evaluateInternal(Edge.java:962)
at org.eclipse.swt.browser.Edge.evaluate(Edge.java:935)
at org.eclipse.swt.browser.WebBrowser.evaluate(WebBrowser.java:405)
at org.eclipse.swt.browser.Browser.evaluate(Browser.java:734)
at org.eclipse.swt.browser.Browser.evaluate(Browser.java:683)
at org.eclipse.lsp4e.operations.hover.FocusableBrowserInformationControl.safeEvaluate(FocusableBrowserInformationControl.java:144)
at org.eclipse.lsp4e.operations.hover.FocusableBrowserInformationControl.updateBrowserSize(FocusableBrowserInformationControl.java:111)
at org.eclipse.lsp4e.operations.hover.FocusableBrowserInformationControl.lambda$0(FocusableBrowserInformationControl.java:91)
at org.eclipse.swt.browser.ProgressListener$2.completed(ProgressListener.java:97)
at org.eclipse.swt.browser.Edge.lambda$43(Edge.java:1178)
at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:40)
at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:132)
at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:4135)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3751)
at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$5.run(PartRenderingEngine.java:1151)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:339)
at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1042)
at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:153)
at org.eclipse.ui.internal.Workbench.lambda$3(Workbench.java:678)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:339)
at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:583)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:173)
[....]
org.eclipse.swt.SWTException: Cannot read properties of null (reading 'scrollHeight')
at org.eclipse.swt.browser.Edge.evaluateInternal(Edge.java:962)
at org.eclipse.swt.browser.Edge.evaluate(Edge.java:935)
at org.eclipse.swt.browser.WebBrowser.evaluate(WebBrowser.java:405)
at org.eclipse.swt.browser.Browser.evaluate(Browser.java:734)
at org.eclipse.swt.browser.Browser.evaluate(Browser.java:683)
at org.eclipse.lsp4e.operations.hover.FocusableBrowserInformationControl.safeEvaluate(FocusableBrowserInformationControl.java:144)
at org.eclipse.lsp4e.operations.hover.FocusableBrowserInformationControl.updateBrowserSize(FocusableBrowserInformationControl.java:116)
at org.eclipse.lsp4e.operations.hover.FocusableBrowserInformationControl.lambda$0(FocusableBrowserInformationControl.java:91)
at org.eclipse.swt.browser.ProgressListener$2.completed(ProgressListener.java:97)
at org.eclipse.swt.browser.Edge.lambda$43(Edge.java:1178)
at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:40)
at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:132)
at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:4135)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3751)
at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$5.run(PartRenderingEngine.java:1151)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:339)
at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1042)
at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:153)
at org.eclipse.ui.internal.Workbench.lambda$3(Workbench.java:678)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:339)
at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:583)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:173)
[....]
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in FocusableBrowserInformationControl.java, especially updateBrowserSize and safeEvaluate, where the stack traces show the failures. Reproduce the issue by quickly hovering over different document regions and observe the browser evaluation calls. Done means those interactions no longer log null scrollWidth or scrollHeight SWTExceptions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100