eclipse-lsp4e / eclipse-lsp4e/lsp4e
Do not invoke completion proposal on statement terminator
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 85
- Forks
- 69
- Avg merge
- 8h 33m
- Merged PRs (30d)
- 6
Description
When using the completion proposals on typing (code completion/ content assist):
the proposals are still invoked when a statement terminator (like ;) has been entered.
When pressing enter, the proposal is used an not a new line has been added. See this cdt-lsp issue: https://github.com/eclipse-cdt/cdt-lsp/issues/550
The proposal is valid since in C++ its allowed to start the next statement after a space (see https://github.com/clangd/clangd/issues/2508#issuecomment-3344772007)
IMO in 90% the user wants to enter a new line after a ;
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No source file or test is named in the issue. Start by tracing the completion-proposal-on-typing entry point in Eclipse LSP4E, then compare the linked cdt-lsp and clangd discussions; it is done when a statement terminator does not invoke a proposal and pressing Enter inserts a new line.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- developer-experience, tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100