eclipse-jdt / eclipse-jdt/eclipse.jdt.ui
In Dark Them the Java editor is very "colorful"
- Dominant language
- Java
- Stars
- 59
- Forks
- 127
- Avg merge
- 23h 30m
- Merged PRs (30d)
- 35
Description
On this year's OCX I was involved in a discussion that the Java Editor is very colorful in the dark theme and that this is the reason why some people don't like it.
Currently the dark theme syntax colors for Java look like this (see the preview part):
In the light time a lot less "semantic coloring" is enabled. It looks like this:
The case is that JDT's dark theme css does enable a lot of the semantic colors check boxes like. e.g. in: https://github.com/eclipse-jdt/eclipse.jdt.ui/blob/f9457bea909e316282dd2b7aec5576aff6e25e99/org.eclipse.jdt.ui/css/e4-dark_jdt_syntaxhighlighting.css#L48
We could turn off some of the "semantic coloring" in the dark theme. I would propose something like this:
In this proposal semantic colors are used in the dark them for the same "semantic positions" as in the light theme.
What do you think ? I could provide a PR for that.
Contributor guide
Research direction
Start with org.eclipse.jdt.ui/css/e4-dark_jdt_syntaxhighlighting.css at the linked semantic-coloring settings, and compare it with the light theme CSS. Adjust the dark theme so semantic coloring matches the positions shown in the proposal, then verify the Java editor's dark-theme preview against the referenced screenshots.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- design
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100