eclipse-jdt / eclipse-jdt/eclipse.jdt.ui
Improve newly added code in MethodProposalInfo.resolveMember()
- Dominant language
- Java
- Stars
- 59
- Forks
- 127
- Avg merge
- 1d 8h
- Merged PRs (30d)
- 37
Description
The PR https://github.com/eclipse-jdt/eclipse.jdt.ui/pull/2293 introduce new changes to the MethodProposalInfo.resolveMember() to select the record component field rather than the method. This works for the problem at hand, where we need the completion Javadoc to be fetched from the enclosing type. But this not perfect because other clients of this method might rather a null (for a method) than a record component. I am raising this so someone more knowledgeable in this area can take a look and see if this can be improved.
Contributor guide
Research direction
Start by reviewing PR 2293 and the current MethodProposalInfo.resolveMember() implementation. Trace the callers of this method, especially the record-component and completion-Javadoc cases, to determine whether selecting a record component or returning null is correct for each client. Done means the behavior is consistent for all callers without regressing the original completion case.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- devtools
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100