eclipse-jdt / eclipse-jdt/eclipse.jdt.ui
[Bug][Inline Method Refactoring] Inline Method refactoring for Generic superclass with a specific type produces uncompilable program
- Dominant language
- Java
- Stars
- 59
- Forks
- 127
- Avg merge
- 23h 30m
- Merged PRs (30d)
- 35
Description
## Steps to reproduce
1. Create a class named A:
```
public class A {
void superMethod(T t) {}
}
```
2. Then, create a class named B:
```
public class B extends A {
void methodToBeInlined() {
super.superMethod("Hello");
}
static void callingMethod(B instance) {
instance.methodToBeInlined(); // attempt to inline this call
}
}
```
3. Left click `methodToBeInlined()` in `instance.methodToBeInlined();` like I comment in class B. Then, right click -> Refactor -> Inline. Use default configuration to inline this method like following, click ok:

The program is successfully refactored without any warning or exception. The refactored program is following, which contains syntax error:
```
public class A {
void superMethod(T t) {}
}
public class B extends A {
void methodToBeInlined() {
super.superMethod("Hello");
}
static void callingMethod(B instance) {
super.superMethod("Hello"); // syntax error
}
}
```
## Environment
### OS Version
Windows 10, 64-bit Operating System, x64-based processor
### Eclipse Version
Eclipse IDE for Enterprise Java and Web Developers (includes Incubating components)
Version: 2024-09 (4.33.0)
Build id: 20240905-0614
### JDK Version
java version "22.0.1" 2024-04-16
Java(TM) SE Runtime Environment (build 22.0.1+8-16)
Java HotSpot(TM) 64-Bit Server VM (build 22.0.1+8-16, mixed mode, sharing)
Contributor guide
Research direction
Reproduce the issue in Eclipse using the A and B classes from the report, then start from the Inline Method refactoring implementation and its existing tests. The fix is done when inlining the call preserves a compilable reference to the generic superclass method, with coverage for this example.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- developer-experience, tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100