eclipse-jdt / eclipse-jdt/eclipse.jdt.core

Should NameEnvironment.computeClasspathLocations() consider the release also for source locations?

Open
#5,246 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
237
Forks
195
Avg merge
1d 12h
Merged PRs (30d)
47

Description

Method `NameEnvironment.computeClasspathLocations(IWorkspaceRoot, JavaProject, Map, int)` may use the `releaseTarget` to
* distinguish modular / non-modular builds
* filter output folders
* select the correct module-info.java (with #4534)

I would think that also `sourceLocations` should be filtered in MR projects. This should then be done before any ModulePathEntry is created (which holds a reference to all applicable source locations).

Contributor guide

Open the contributing guide

Research direction

Start at NameEnvironment.computeClasspathLocations(IWorkspaceRoot, JavaProject, Map, int) and trace how releaseTarget and sourceLocations are handled before any ModulePathEntry is created. Done means source locations in multi-release projects are filtered for the selected release while the existing modular, output-folder, and module-info handling remains correct.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
compilers
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.