eclipse-jdt / eclipse-jdt/eclipse.jdt.core

[Internal] org.eclipse.jdt.internal.compiler.lookup.SourceTypeBinding.memberTypes computation code could be simpler.

Open
#4,841 1 comment 0 reactions 1 assignee Claimed by @srikanth-sankaran View on GitHub
Dominant language
Java
Stars
237
Forks
195
Avg merge
1d 12h
Merged PRs (30d)
47

Description

While working on https://github.com/eclipse-jdt/eclipse.jdt.core/issues/4823 I notice that the code and interaction between these methods:

`org.eclipse.jdt.internal.compiler.lookup.SourceTypeBinding.memberTypes()`
`org.eclipse.jdt.internal.compiler.lookup.SourceTypeBinding.setMemberTypes(ReferenceBinding[])`
`org.eclipse.jdt.internal.compiler.lookup.SourceTypeBinding.sortedMemberTypes()`

makes for somewhat complicated reading and can be simplified quite a bit.

In particular, it is not clear we need `org.eclipse.jdt.internal.compiler.lookup.SourceTypeBinding.memberTypesSorted` at all, this should/could be subsumed by `TagBits.HasUnresolvedMemberTypes` itself.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.