eclipse-jdt / eclipse-jdt/eclipse.jdt.core

Names ProblemReporter.validateX

Open
#4,177 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
237
Forks
195
Avg merge
1d 12h
Merged PRs (30d)
47

Description

Every once in a while I get confused seeing code like
```java
if (problemReporter().validateJavaFeatureSupport(..)) {
...
}
```

In my book "validate" relates to "valid", so if it answers true I expect the thing to be valid.

I'm sure whoever came up with this terminology (@jarthana ?) has his own way to read this, so I don't want to unilaterally override this, and simply inverting the logic while keeping the name only adds to the confusion. But perhaps we can come up with a name pattern that speaks to all of us?

Cc: @mpalat @srikanth-sankaran

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.