eclipse-jdt / eclipse-jdt/eclipse.jdt.core

performance: ReferenceBinding.superInterfaces() with redundant super interfaces

Open
#3,601 4 comments 0 reactions 0 assignees View on GitHub
performance
Dominant language
Java
Stars
237
Forks
195
Avg merge
1d 10h
Merged PRs (30d)
49

Description

for example
org.eclipse.jdt.internal.compiler.lookup.BinaryTypeBinding.superInterfaces() recursively calls ReferenceBinding.superInterfaces() (without even using the returned type (`// make super-type resolving recursive for propagating typeBits downwards`) and does not protect against redundant super interfaces
sampling data from https://github.com/eclipse-jdt/eclipse.jdt.core/pull/3387#issuecomment-2606816518:
![Image](https://github.com/user-attachments/assets/69621b4b-0c20-427c-83aa-e4046ba42c9b)
@fedejeanne you may want to protect this against already visited types too.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.