eclipse-jdt / eclipse-jdt/eclipse.jdt.core

Test or remove InstanceOfExpression.setPatternIsTotalType()

Open
#2,880 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
237
Forks
195
Avg merge
1d 12h
Merged PRs (30d)
47

Description

Method `InstanceOfExpression.setPatternIsTotalType()` was introduced via f76142949e0d0c97740af93446735d49ae65b3a5 but as [stated before](https://github.com/eclipse-jdt/eclipse.jdt.core/pull/2549#discussion_r1701885030), this code is not necessary to make 100% tests pass.

@mpalat as you added this, you should be given a chance to either
* write a test case that **needs** it, or
* otherwise argue why it is good to have, or
* confirm that it is unnecessary code 😄

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.