eclipse-jdt / eclipse-jdt/eclipse.jdt.core

[Smell] JavaModelManager.shutdown() join on Job family that seems unused

Open
#1,212 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
237
Forks
195
Avg merge
1d 10h
Merged PRs (30d)
49

Description

While working on #1190 and investigating the behavior of JavaModelManager, I noticed that its `shutdown` method calls `JobManager.join(JavaCore.PLUGIN_ID,...)` to "wait for the initialization job to finish". However, it looks like nowhere in JDT Core a job is created with a `belongsTo` that makes it part of the `JavaCore.PLUGIN_ID`. So it looks like this `join` is a no-op and could be removed; or that an important job misses instructions to be part of this `JavaCore.PLUGIN_ID` family.

Contributor guide

Open the contributing guide

Research direction

Start with JavaModelManager.shutdown() and trace its JobManager.join(JavaCore.PLUGIN_ID, ...) call, then inspect JDT Core jobs for belongsTo usage with that family. Determine whether the join is unused or whether an initialization job is missing family membership; done means documenting and applying the resolved cleanup or correction.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
devtools
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.