eclipse-iceoryx / eclipse-iceoryx/iceoryx

Improving `units::Duration`

Open
#536 4 comments 1 reaction 1 assignee Claimed by @enkeyz View on GitHub
enhancement globex good first issue
Dominant language
C++
Stars
2.2k
Forks
492
Avg merge
18h 57m
Merged PRs (30d)
1

Description

## Brief feature description

The `units::Duration` class could have same additional features and improvements.

## Detailed information

- [x] rename the creation methods like `milliseconds` to `fromMilliseconds`
- some getter methods should then be renamed, e.g. `milliSeconds` -> `milliseconds` or `toMilliseconds`
- no final decision, please ask before starting with this
- [ ] conversion to/from all `chrono` types
- [x] `operator+=`, `operator-=` and `operator*=` https://github.com/eclipse-iceoryx/iceoryx/pull/501#discussion_r564463012
- [ ] abstractions for `TimePoint` for monotonic and system clock https://github.com/eclipse-iceoryx/iceoryx/pull/501#discussion_r560061177
- needs to be discussed and maybe another issue should be used for this

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.