eclipse-iceoryx / eclipse-iceoryx/iceoryx

Add default alignment to `loan` method in `popo::UntypedServerImpl` and `popo:UntypedClientImpl`

Open
#1,845 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
C++
Stars
2.2k
Forks
492
Avg merge
18h 57m
Merged PRs (30d)
1

Description

## Brief feature description

Updating `rmw_iceoryx` to Blueberry `v2.0.2` revealed that unlike with pub/sub, there is no `loan` with the default alignment `iox::CHUNK_DEFAULT_USER_PAYLOAD_ALIGNMENT`, see https://github.com/ros2/rmw_iceoryx/pull/84

## Detailed information

* Add default values to `loan` methods in `popo::UntypedServerImpl` and `popo:UntypedClientImpl` like below

https://github.com/eclipse-iceoryx/iceoryx/blob/3d22bd4c95e6dc842ef9ed769ea3127786d8a82c/iceoryx_posh/include/iceoryx_posh/internal/popo/untyped_publisher_impl.hpp#L50-L54

Contributor guide

Open the contributing guide

Research direction

Start by comparing the loan methods in popo::UntypedServerImpl and popo::UntypedClientImpl with the default-alignment pattern in iceoryx_posh/include/iceoryx_posh/internal/popo/untyped_publisher_impl.hpp. Add the default alignment to both methods, then build the affected iceoryx component and verify that existing loan callers still compile and behave correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
distributed-systems
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.