eclipse-iceoryx / eclipse-iceoryx/iceoryx

Replace `NotificationCallback` with `cxx::function`

Open
#1,097 0 comments 0 reactions 0 assignees View on GitHub
refactoring
Dominant language
C++
Stars
2.2k
Forks
492
Avg merge
18h 57m
Merged PRs (30d)
1

Description

## Brief feature description

Since a heap-free and exception-free `cxx::function` is now available use them, instead of `NotificationCallback` in `popo::WaitSet` and `popo::Listener`.

## Detailed information

* With this change, one will be able to store arbitrary callables inside `WaitSet` and `Listener`. Currently only static methods or free functions are allowed.

Contributor guide

Open the contributing guide

Research direction

Start by locating the popo::WaitSet and popo::Listener definitions and their uses of NotificationCallback. Check how cxx::function is already used, then update both APIs so arbitrary callables can be stored instead of only static methods or free functions; done means both components use cxx::function consistently.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
distributed-systems
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.