eclipse-ee4j / eclipse-ee4j/tyrus

GrizzlyServerFilter has a public constructor, but is not public, while WebSocketAddOn is public but has no public constructor

Open
#945 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
128
Forks
49
PR merge metrics
No merged PRs in 30d

Description

In Tyus version 2.2.1 (latest I believe) GrizzlyServerFilter has a public constructor, but is not public, while WebSocketAddOn is public but has no public constructor, so I've needed to copy GrizzlyServerFilter and create my own WebsocketAddOn, and this makes no sense. Are you afraid someone might extend one of these classes, from this open source project? You're actually enforcing that behavior. Please either make GrizzlyServerFilter a public class, or make the constructor in WebSocketAddOn public, but preferably *both*.

Shall I create a pull request?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.