eclipse-ee4j / eclipse-ee4j/soteria
Split SubjectParser code in Application server specific classes
- Dominant language
- Java
- Stars
- 72
- Forks
- 34
- PR merge metrics
- No merged PRs in 30d
Description
The SubjectParser contains package names for different servers within Strings.
This leads to some unmaintainable code.
Proposal (see also https://github.com/javaee-security-spec/soteria/issues/69#issuecomment-308394262) is to create separate maven artifacts with the application server specific code.
**Proposal**
- Interface with methods to retrieve caller and groups (getGroupsFromPrincipals, getCallerPrincipalFromPrincipals, ...)
- Server specific project contains an implementation of the interface which is defined as CDI bean. CdiUtils#getBeanReference(java.lang.Class, java.lang.annotation.Annotation...) can be used then to retrieve the implementation.
Contributor guide
Assessment
This issue has not been assessed yet.