eclipse-ee4j / eclipse-ee4j/soteria
@OpenIdAuthenticationMechanismDefinition.extraParametersExpression is not evaluated
- Dominant language
- Java
- Stars
- 72
- Forks
- 34
- PR merge metrics
- No merged PRs in 30d
Description
`org.glassfish.soteria.mechanisms.openid.controller.ConfigurationController#buildConfig` does evaluate `extraParameters` but it does not evaluate `extraParametersExpression`.
The Jakarte EE 10 documentation of `OpenIdAuthenticationMechanismDefinition` does not mention the result type of the EL in `extraParametersExpression` attribute. I'm not sure if the EL should return a String array or a String where the name=value pairs are separated by a comma (or something similar).
Contributor guide
Research direction
Start at org.glassfish.soteria.mechanisms.openid.controller.ConfigurationController#buildConfig, where extraParameters is evaluated but extraParametersExpression is not. Read the Jakarta EE 10 documentation for OpenIdAuthenticationMechanismDefinition to determine the expected EL result type. Done means the expression is evaluated consistently and its result type is documented or otherwise resolved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- authentication, security
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100