eclipse-ee4j / eclipse-ee4j/soteria

Try streamline Utils class with Java 8 Objects, maybe make internal

Open
#27 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
73
Forks
35
PR merge metrics
No merged PRs in 30d

Description

I noticed a `Utils` class in Soteria. While we use Java 8 as the minimum version (see https://jcp.org/en/jsr/detail?id=375) it is worth asking if this should be part of the Soteria API/SPI (non-standard but reusable) or it's simply an internal helper class? Either way it would be good to adjust it to Java 8 `Objects`. Which offers a `nonNull()` method for a single object. It is probably worth trying to call it internally instead of our own logic.

If the class was nevertheless considered an internal utility class, then maybe it's best to move it to an "internal" package. Where OSGi is involved that package should be "non-exposed" same for future use by Java SE 9 and Jigsaw.

Contributor guide

Open the contributing guide

Research direction

Start by locating the Utils class in Soteria and checking whether it is part of the API/SPI and how its package is exposed through OSGi. Review its null-checking logic against Java 8 Objects.nonNull(); done means resolving the public-versus-internal decision and applying the corresponding package exposure consistently.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
security
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.