eclipse-ee4j / eclipse-ee4j/mojarra-jsf-extensions

PartialTraversalViewRootHelper breaks with apache MyFacces

Open
#89 4 comments 0 reactions 1 assignee Claimed by @glassfishrobot View on GitHub
Component: runtime ERR: Assignee Priority: Major Type: Bug
Dominant language
Java
Stars
1
Forks
3
PR merge metrics
No merged PRs in 30d

Description

Contrary to the FAQ "What is the Relationship Between jsf-extensions and the
Glassfish Project?", the PartialTraversalViewRootHelper class does leverage an
implementation specific detail when it does that nasty
"getBroadcastEventsMethod()" bit.
Now that MyFaces also implements the JSF 1.2 standard (and is installed as the
default JSF impl on Geronimo, IBM WebSphere), it would be nice if this
jsf-extensions library also worked correctly with it.
I haven't tested this, but as a quick fix it looks like the MyFaces equivalent
to UIViewRoot method:
private void broadcastEvents(FacesContext context, PhaseId phaseId)
would be:
private void _broadcastForPhase(PhaseId phaseId)
So the getBroadcastEventsMethod() could look for either. The calling code would
have to allow for the one-less parameter also.

Of course, if you fix this, I don't know if there are any other
incompatibilities. Ultimately not having to rely on private methods has to be
better too. If there is a functionality gap, then perhaps the JSF API spec needs
to be tweeked to include such a method.
#### Environment
Operating System: All
Platform: All
#### Affected Versions
[current]

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.