eclipse-ee4j / eclipse-ee4j/metro-wsit
dont instantiate DefaultSTSAuthorizationProvider everytime
- Dominant language
- Java
- Stars
- 6
- Forks
- 21
- Avg merge
- 10h 2m
- Merged PRs (30d)
- 1
Description
we are instantiating the DefaultSTSAuthorizationProvider everytime. Instead, if
we have a static object, it will reduce the number of objects created. The
relevant code is
public static STSAuthorizationProvider getSTSAuthorizationProvider() {
STSAuthorizationProvider authzProvider = null;
final ServiceFinder finder =
ServiceFinder.find(STSAuthorizationProvider.class);
if (finder != null && finder.toArray().length > 0)
{ authzProvider = finder.toArray()[0]; }
else
{ authzProvider = new DefaultSTSAuthorizationProvider(); }
return authzProvider;
}
#### Environment
Operating System: All
Platform: Sun
#### Affected Versions
[current]
Source: [https://github.com/javaee/metro-wsit/issues/468](https://github.com/javaee/metro-wsit/issues/468)
Author: glassfishrobot
Contributor guide
Research direction
Locate the getSTSAuthorizationProvider() entry point shown in the issue and inspect how ServiceFinder and DefaultSTSAuthorizationProvider are used. Preserve the ServiceFinder provider-selection behavior while avoiding repeated DefaultSTSAuthorizationProvider creation, then verify the relevant existing test coverage for authorization-provider lookup.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- authorization, backend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100