eclipse-ee4j / eclipse-ee4j/jersey

Using unstable netty api that has been removed broke jersey-container-netty-http

Open
#3,697 1 comment 0 reactions 0 assignees View on GitHub
Component: connectors netty
Dominant language
Java
Stars
730
Forks
382
PR merge metrics
No merged PRs in 30d

Description

I do not have a solution at this time. Not that familiar with netty, and seems replacement class is not a drop in replacement. Jersey is using a unstable Netty api that was present in <=4.1.14, but removed in versions since >=4.1.15, in this [commit](https://github.com/netty/netty/commit/74f24a). Which breaks [HttpVersionChooser](https://github.com/jersey/jersey/blob/master/containers/netty-http/src/main/java/org/glassfish/jersey/netty/httpserver/HttpVersionChooser.java#L72) and [JerseyServerInitializer](https://github.com/jersey/jersey/blob/master/containers/netty-http/src/main/java/org/glassfish/jersey/netty/httpserver/JerseyServerInitializer.java#L140) usage of the removed class, Http2Codec.

I briefly looked into replacing Http2Codec with Http2MultipleCodec but was unsuccessful. I may see about a PR time permitting.Till then mentioning for others to be aware, and for the record.

Contributor guide

Open the contributing guide

Research direction

Start with containers/netty-http/src/main/java/org/glassfish/jersey/netty/httpserver/HttpVersionChooser.java around line 72 and JerseyServerInitializer.java around line 140. Review Netty commit 74f24a and the Http2Codec removal, then compare the available replacement APIs. Done means jersey-container-netty-http works with Netty versions at or above 4.1.15.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
api, backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.