eclipse-ee4j / eclipse-ee4j/genericmessagingra
The user name and password is not being used from the com\sun\genericra\GenericJMSRAProperties.java class
- Dominant language
- Java
- Stars
- 2
- Forks
- 5
- PR merge metrics
- No merged PRs in 30d
Description
[fixes.zip](https://github.com/javaee/glassfish-genericjmsra/files/1414891/fixes.zip)
Code fixes are in classes, com\sun\genericra\outbound\ManagedJMSConnectionFactory.java, com\sun\genericra\outbound\ManagedQueueConnectionFactory.java and com\sun\genericra\outbound\ManagedTopicConnectionFactory.java
two method updates, the same change for all three classes (added <--- new line for the changes).
protected XAConnection createXAConnection(PasswordCredential pc, ConnectionFactory cf)
throws JMSException
{
if(pc != null && !pc.getUserName().equals(""))
return ((XAConnectionFactory)cf).createXAConnection(pc.getUserName(), new String(pc.getPassword()));
if(getUserName() != null && getPassword() != null) <--- new line
return ((XAConnectionFactory)cf).createXAConnection(getUserName(), getPassword()); <--- new line
else
return ((XAConnectionFactory)cf).createXAConnection();
}
protected Connection createConnection(PasswordCredential pc, ConnectionFactory cf)
throws JMSException
{
if(pc != null && !pc.getUserName().equals(""))
return cf.createConnection(pc.getUserName(), new String(pc.getPassword()));
if(getUserName() != null && getPassword() != null) <---- new line
return cf.createConnection(getUserName(), getPassword()); <---- new line
else
return cf.createConnection();
}
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.