eclipse-edc / eclipse-edc/Connector
Idempotency feature on DSP is actually doing nothing
- Dominant language
- Java
- Stars
- 424
- Forks
- 300
- Avg merge
- 13h 11m
- Merged PRs (30d)
- 35
Description
# Feature Request
Some time ago we implemented [idempotency on the DSP layer](https://github.com/eclipse-edc/Connector/issues/2993) so duplicate messages can be deduplicated.
This feature was based on the assumption that the DSP messages bring an unique `@id`, but this is not the case, [according to the DSP 2025/1 spec](https://eclipse-dataspace-protocol-base.github.io/DataspaceProtocol).
In fact, the `ProcessRemoteMessage`, the abstraction for all the DSP messages, has a "if null, set random" id logic:
https://github.com/eclipse-edc/Connector/blob/52cec0c7dcecc93f47c5c5dcb3d415d42032d7c7/spi/common/core-spi/src/main/java/org/eclipse/edc/spi/types/domain/message/ProcessRemoteMessage.java#L123-L126
that means that every message will be different from the previous.
## Solution Proposal
My proposal is to chop off this feature as it brings no real value at the moment
Contributor guide
Assessment
This issue has not been assessed yet.