eclipse-cyclonedds / eclipse-cyclonedds/cyclonedds-python

Error in IDL generator with structs inheritance which identifiers are Python keywords

Open
#173 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
110
Forks
68
Avg merge
1h 8m
Merged PRs (30d)
1

Description

Hello,

I have detected an error in IDL generator with structs inheritance which identifiers are Python keywords.

module module_test {
    struct and {
        char var;
    };
    struct child : and {
        char var2;
    };
};

This problem is related to the solution we gave on #105. This case couldn't be tested because bug #162 wasn't fixed by then. So, we couldn't test and verify structs inheritance with keywords. As soon as #172 will be solved I will be able to test this error, but I have locally solved this issue. I will share a PR with it.

Best regards.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the IDL generator and reproduce the issue's module example, including the inherited struct whose identifier is a Python keyword. Check the behavior after the fixes referenced in #162 and #172; done means struct inheritance with keyword identifiers generates successfully without the reported error.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.