eclipse-cdt-cloud / eclipse-cdt-cloud/vscode-memory-inspector

Transmit whole preference section rather than individual fields

Open
#90 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
17
Forks
25
Avg merge
3d 22h
Merged PRs (30d)
8

Description

We are now transmitting quite a few separate preferences into the webview, and we're doing so by fetching every value we're interested in separately and then combining them into an object.

We could make that code less verbose if we simply fetched all of the preferences associated with the plugin at once and transmitted that to the webview:

```typescript
return vscode.workspace.getConfiguration().get(manifest.PACKAGE_NAME) as OurMessageInterface;
```

The downside would be coupling between the `package.json` declarations and our data formats. But there's already a lot of coupling, since we're just pulling out the fields declared in the `package.json` one by one anyway.

_Originally posted by @colin-grant-work in https://github.com/eclipse-cdt-cloud/vscode-memory-inspector/pull/89#discussion_r1509380875_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.