eclipse-cdt-cloud / eclipse-cdt-cloud/theia-trace-extension

Require successful build in Gitpod to merge a pull request

Open
#492 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
50
Forks
60
PR merge metrics
No merged PRs in 30d

Description

The current automatic checks allow changes to be merged even if building the extension fails in Gitpod. This means changes that break the Gitpod build can go unnoticed for a while. Since some devs rely on Gitpod to develop and test code and since it's always easiest to fix a problem right when it's caused, not noticing these problems immediately can delay development work and reviews.

Current checks:
![image](https://user-images.githubusercontent.com/28311615/134247749-55b55ebc-1362-48be-a202-0071c4d79f88.png)

## Implementation

Since checks seem to be defined by branch protection rules ([github documentation](https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/defining-the-mergeability-of-pull-requests/managing-a-branch-protection-rule)) in the project's settings, these changes would have to be done by an admin. There aren't many examples of protection rules so it's not clear whether it's possible to create a rule that requires compilation in Gitpod. This requires more investigation.

Contributor guide

Open the contributing guide

Research direction

Start with the repository's branch protection settings and the linked GitHub documentation, then investigate how the Gitpod extension build is exposed as an automatic check. Confirm whether a rule can require that build to succeed before merging. Done means pull requests cannot merge when the Gitpod build fails.

Written by the indexing model from the issue text.

Assessment

Tech stack
github, typescript
Domain
build-system, ci-cd
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.