eclipse-cdt-cloud / eclipse-cdt-cloud/cdt-gdb-adapter

Allowing undefined frames for evaluate requests and variables request

Open
#503 1 comment 0 reactions 1 assignee Claimed by @omarArm View on GitHub
Dominant language
TypeScript
Stars
39
Forks
56
Avg merge
3d 9h
Merged PRs (30d)
2

Description

In the method handling evaluate request, there exist a guard to discard requests without frameIDs that come with a context other than `repl`. I believe it would be a good idea to create a frame handle for global expressions in which undefined frameIDs would fall back to. This would entail the following:

1. Creating a frame handle for global expressions at the beginning of every stackTrace request. StackTrace requests are where frame handles are created. They are later all reset when stopped event and continued event are fired.

2. Remove the guard for undefined frameIDs from evaluate requests and assign undefined frames to the frame handle specified for global expressions. Current behaviour is that undefined frameIDs would get assigned with frame handle -1, which doesn't exist.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.