eclipse-cdt-cloud / eclipse-cdt-cloud/cdt-gdb-adapter

Explicitly set thread ID when getting stack depth

Open
#451 9 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
39
Forks
56
Avg merge
3d 9h
Merged PRs (30d)
2

Description

Found by @jonahgraham during code review:

We have a couple of calls to `mi.sendStackInfoDepth` which do not receive a threadId parameter although we have the knowledge in the surrounding code.

This should in theory be fine because the affected functionality is always executed on the currently selected thread. Which should be correctly selected in GDB. But we should make use of exact knowledge when we have it, like for most of these calls. Especially if there is a lot going on in the GUI which could change the thread selection while operations are in flight.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.