eclipse-cdt-cloud / eclipse-cdt-cloud/cdt-gdb-adapter
Incorrect address (pc) resolution in DisassembleRequest
- Dominant language
- TypeScript
- Stars
- 39
- Forks
- 56
- Avg merge
- 3d 9h
- Merged PRs (30d)
- 2
Description
During the debug session, when user navigates and opens the `Disassembly View` in the VSCode, the Disassembly View focuses on an incorrect line when it is compared program counter (pc) register as shown above:

After a review, I found that the current implementation of the `disassembleRequest` method at the `GDBDebugSessionBase` class are not handling the `instructionOffset` parameters. It seems the `disassembleRequest` implementation requires to be updated to match the DAP reference.
https://microsoft.github.io/debug-adapter-protocol/specification#Requests_Disassemble
@jonahgraham and I already discussed the issue previously, planning to propose an update to solve the issue.
Contributor guide
Assessment
This issue has not been assessed yet.