eclipse-cdt-cloud / eclipse-cdt-cloud/cdt-gdb-adapter

Incorrect address (pc) resolution in DisassembleRequest

Open
#340 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
39
Forks
56
Avg merge
3d 9h
Merged PRs (30d)
2

Description

During the debug session, when user navigates and opens the `Disassembly View` in the VSCode, the Disassembly View focuses on an incorrect line when it is compared program counter (pc) register as shown above:

![image](https://github.com/user-attachments/assets/fc84e46c-a25b-494c-a777-0081c87c93dd)

After a review, I found that the current implementation of the `disassembleRequest` method at the `GDBDebugSessionBase` class are not handling the `instructionOffset` parameters. It seems the `disassembleRequest` implementation requires to be updated to match the DAP reference.
https://microsoft.github.io/debug-adapter-protocol/specification#Requests_Disassemble

@jonahgraham and I already discussed the issue previously, planning to propose an update to solve the issue.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.