FilterEagerLoadingsExtension changes query even when eager loading is disabled
- Dominant language
- PHP
- Stars
- 156
- Forks
- 72
- Avg merge
- 12h 43m
- Merged PRs (30d)
- 203
Description
When eager loading is disabled for a specific operation, our own implementation of FilterEagerLoadingsExtension is still changing the query, which is unexpected and could potentially leads to less optimal queries.
Our implementation:
https://github.com/ecamp/ecamp3/blob/devel/api/src/Doctrine/Orm/Extension/FilterEagerLoadingsExtension.php#L36
Upstream implementation:
https://github.com/api-platform/core/blob/main/src/Doctrine/Orm/Extension/FilterEagerLoadingExtension.php#L51
Verify if this was done on purpose and check if we can copy the few lines from upstream implementation without breaking anything else.
The new subresource operation introduced in https://github.com/ecamp/ecamp3/pull/9849 would be a good test case.
Contributor guide
Assessment
This issue has not been assessed yet.